Adding currency rate for the central bank of Iceland #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurorng
requested review from
benediktvaldez,
koddsson,
kristjanmik and
MiniGod
as code owners
MiniGod
requested changes
Dec 21, 2020
Comment on lines
+21
to
+27
| const name = tds.eq(0).text() | ||
|
|
||
| if (name) { | ||
| currencies.push({ | ||
| shortName: name, | ||
| longName: tds.eq(1).text(), | ||
| value: tds.eq(4).text(), |
There was a problem hiding this comment.
Looks like the html has changed. The table only has 3 columns now so the indexes in the tds.eq calls are wrong.
Suggested change
| const name = tds.eq(0).text() | |
| if (name) { | |
| currencies.push({ | |
| shortName: name, | |
| longName: tds.eq(1).text(), | |
| value: tds.eq(4).text(), | |
| const name = tds.eq(1).text() | |
| if (name) { | |
| currencies.push({ | |
| shortName: name, | |
| longName: tds.eq(0).text().trim(), | |
| value: Number(tds.eq(2).text().replace(',', '.')), |
I'm not sure if the if on line 23 is still valid now that name is from column index 1.
| it('should return an array of objects containing correct fields', (done) => { | ||
| const params = helpers.testRequestParams('/currency/cb') | ||
| const resultHandler = helpers.testRequestHandlerForFields(done, fieldsToCheckFor) | ||
| request(params, resultHandler) |
There was a problem hiding this comment.
Missing mock data for this test.
Here's an example of how to do it: https://github.com/apis-is/apis/blob/1fb161a/endpoints/horses/tests/integration_test.js#L22-L4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new source for the currency endpoint: the currency rate from the Central Bank of Iceland.
Checklist